Rework test matrix and structure

tests/models.py

@@ -0,0 +1,6 @@
+""" Provides a dummy model implementing JSignatureFieldsMixin """
+from jsignature.mixins import JSignatureFieldsMixin
+
+
+class JSignatureTestModel(JSignatureFieldsMixin):
+    pass

tests/settings.py

@@ -0,0 +1,34 @@
+import os
+
+DEBUG = True
+
+BASE_DIR = os.path.dirname(os.path.dirname(__file__))
+
+SECRET_KEY = 'thisisntactuallysecretatall'
+
+ALLOWED_HOSTS = ['*']
+
+DATABASES = {
+    'default': {
+        'ENGINE': 'django.db.backends.sqlite3',
+        'NAME': ':memory:',
+    }
+}
+
+# ROOT_URLCONF = 'tests.urls'
+
+INSTALLED_APPS = [
+    'jsignature',
+    'tests',
+]
+
+PASSWORD_HASHERS = {
+    'django.contrib.auth.hashers.MD5PasswordHasher',
+}
+
+TEMPLATES = [
+    {
+        'BACKEND': 'django.template.backends.django.DjangoTemplates',
+        'APP_DIRS': True,
+    },
+]

tests/test_fields.py

@@ -0,0 +1,62 @@
+import json
+import six
+
+from django.test import SimpleTestCase
+from django.core.exceptions import ValidationError
+
+from jsignature.fields import JSignatureField
+from jsignature.forms import JSignatureField as JSignatureFormField
+
+
+class JSignatureFieldTest(SimpleTestCase):
+
+    def test_to_python_empty(self):
+        f = JSignatureField()
+        for val in ['', [], '[]']:
+            self.assertIsNone(f.to_python(val))
+
+    def test_to_python_correct_value_python(self):
+        f = JSignatureField()
+        val = [{"x": [1, 2], "y": [3, 4]}]
+        self.assertEquals(val, f.to_python(val))
+
+    def test_to_python_correct_value_json(self):
+        f = JSignatureField()
+        val = [{"x": [1, 2], "y": [3, 4]}]
+        val_str = '[{"x":[1,2], "y":[3,4]}]'
+        self.assertEquals(val, f.to_python(val_str))
+
+    def test_to_python_incorrect_value(self):
+        f = JSignatureField()
+        val = 'foo'
+        self.assertRaises(ValidationError, f.to_python, val)
+
+    def test_get_prep_value_empty(self):
+        f = JSignatureField()
+        for val in ['', [], '[]']:
+            self.assertIsNone(f.get_prep_value(val))
+
+    def test_get_prep_value_correct_values_python(self):
+        f = JSignatureField()
+        val = [{"x": [1, 2], "y": [3, 4]}]
+        val_prep = f.get_prep_value(val)
+        self.assertIsInstance(val_prep, six.string_types)
+        self.assertEquals(val, json.loads(val_prep))
+
+    def test_get_prep_value_correct_values_json(self):
+        f = JSignatureField()
+        val = [{"x": [1, 2], "y": [3, 4]}]
+        val_str = '[{"x":[1,2], "y":[3,4]}]'
+        val_prep = f.get_prep_value(val_str)
+        self.assertIsInstance(val_prep, six.string_types)
+        self.assertEquals(val, json.loads(val_prep))
+
+    def test_get_prep_value_incorrect_values(self):
+        f = JSignatureField()
+        val = type('Foo')
+        self.assertRaises(ValidationError, f.get_prep_value, val)
+
+    def test_formfield(self):
+        f = JSignatureField()
+        cls = f.formfield().__class__
+        self.assertTrue(issubclass(cls, JSignatureFormField))

tests/test_forms.py

@@ -0,0 +1,27 @@
+from django.test import SimpleTestCase
+from django.core.exceptions import ValidationError
+
+from jsignature.widgets import JSignatureWidget
+from jsignature.forms import JSignatureField
+
+
+class JSignatureFormFieldTest(SimpleTestCase):
+
+    def test_widget(self):
+        f = JSignatureField()
+        self.assertIsInstance(f.widget, JSignatureWidget)
+
+    def test_to_python_empty_values(self):
+        f = JSignatureField()
+        for val in ['', [], '[]']:
+            self.assertIsNone(f.to_python(val))
+
+    def test_to_python_correct_values(self):
+        f = JSignatureField()
+        val = '[{"x":[1,2], "y":[3,4]}]'
+        self.assertEquals([{'x': [1, 2], 'y': [3, 4]}], f.to_python(val))
+
+    def test_to_python_incorrect_values(self):
+        f = JSignatureField()
+        val = 'foo'
+        self.assertRaises(ValidationError, f.to_python, val)

tests/test_mixins.py

@@ -0,0 +1,47 @@
+from datetime import date
+from django.test import TestCase
+
+from .models import JSignatureTestModel
+
+
+class JSignatureFieldsMixinTest(TestCase):
+    def test_save_create(self):
+        # If an object is created signed, signature date must be set
+        signature_value = [{"x": [1, 2], "y": [3, 4]}]
+        i = JSignatureTestModel(signature=signature_value)
+        i.save()
+        i = JSignatureTestModel.objects.get(pk=i.pk)
+        self.assertEqual(date.today(), i.signature_date.date())
+
+    def test_save_no_change(self):
+        # If signature doesn't change, signature date must not be updated
+        signature_value = [{"x": [1, 2], "y": [3, 4]}]
+        i = JSignatureTestModel(signature=signature_value)
+        i.save()
+        i.signature_date = date(2013, 1, 1)
+        i.save()
+        i = JSignatureTestModel.objects.get(pk=i.pk)
+        self.assertEqual(date(2013, 1, 1), i.signature_date.date())
+
+    def test_save_change(self):
+        # If signature changes, signature date must be updated too
+        signature_value = [{"x": [1, 2], "y": [3, 4]}]
+        new_signature_value = [{"x": [5, 6], "y": [7, 8]}]
+        i = JSignatureTestModel(signature=signature_value,
+                                signature_date=date(2013, 1, 1))
+        i.save()
+        i.signature_date = date(2013, 1, 1)
+        i.signature = new_signature_value
+        i.save()
+        i = JSignatureTestModel.objects.get(pk=i.pk)
+        self.assertEqual(date.today(), i.signature_date.date())
+
+    def test_save_none(self):
+        # If sinature is set to None, it must be the same for signature_date
+        signature_value = [{"x": [1, 2], "y": [3, 4]}]
+        i = JSignatureTestModel(signature=signature_value)
+        i.save()
+        i.signature = None
+        i.save()
+        i = JSignatureTestModel.objects.get(pk=i.pk)
+        self.assertIsNone(i.signature_date)

tests/test_utils.py

@@ -0,0 +1,36 @@
+import json
+import os
+import imghdr
+from PIL import Image
+from django.test import SimpleTestCase
+
+from jsignature.utils import draw_signature
+
+DUMMY_VALUE = [{"x": [205, 210], "y": [59, 63]},
+               {"x": [205, 207], "y": [67, 64]}]
+DUMMY_STR_VALUE = json.dumps(DUMMY_VALUE)
+
+
+class UtilsTest(SimpleTestCase):
+
+    def test_inputs_bad_str_value(self):
+        self.assertRaises(ValueError, draw_signature, 'foo_bar')
+
+    def test_inputs_bad_type_value(self):
+        self.assertRaises(ValueError, draw_signature, object())
+
+    def test_inputs_good_list_value(self):
+        draw_signature(DUMMY_VALUE)
+
+    def test_inputs_good_str_value(self):
+        draw_signature(DUMMY_STR_VALUE)
+
+    def test_outputs_as_file(self):
+        output = draw_signature(DUMMY_VALUE, as_file=True)
+        self.assertTrue(os.path.isfile(output))
+        self.assertIsNotNone(imghdr.what(output))
+
+    def test_outputs_as_image(self):
+        output = draw_signature(DUMMY_VALUE)
+        self.assertTrue(issubclass(output.__class__, Image.Image))
+        self.assertTrue(all(output.getbbox()))

tests/test_widgets.py

@@ -0,0 +1,83 @@
+import json
+from pyquery import PyQuery as pq
+import six
+
+from django.test import SimpleTestCase
+from django.core.exceptions import ValidationError
+
+from jsignature.widgets import JSignatureWidget
+from jsignature.settings import JSIGNATURE_HEIGHT
+
+
+class JSignatureWidgetTest(SimpleTestCase):
+
+    def test_default_media(self):
+        widget = JSignatureWidget()
+        media = widget.media
+        media_js = list(media.render_js())
+        self.assertEqual(3, len(media_js))
+        media_js_str = "".join(media_js)
+        self.assertIn('jSignature.min.js', media_js_str)
+        self.assertIn('django_jsignature.js', media_js_str)
+        media_css = list(media.render_css())
+        self.assertEquals([], media_css)
+
+    def test_init(self):
+        w = JSignatureWidget()
+        self.assertEquals({}, w.jsignature_attrs)
+        given_attrs = {'width': 300, 'height': 100}
+        w = JSignatureWidget(jsignature_attrs=given_attrs)
+        self.assertEquals(given_attrs, w.jsignature_attrs)
+
+    def test_build_jsignature_id(self):
+        w = JSignatureWidget()
+        id = w.build_jsignature_id('foo')
+        self.assertEqual('jsign_foo', id)
+
+    def test_build_jsignature_config(self):
+        w = JSignatureWidget(jsignature_attrs={'width': 400})
+        config = w.build_jsignature_config()
+        self.assertEqual(400, config.get('width'))
+        self.assertEqual(JSIGNATURE_HEIGHT, config.get('height'))
+
+    def test_prep_value_empty_values(self):
+        w = JSignatureWidget()
+        for val in ['', [], '[]']:
+            self.assertEqual('[]', w.prep_value(val))
+
+    def test_prep_value_correct_values_python(self):
+        w = JSignatureWidget()
+        val = [{"x": [1, 2], "y": [3, 4]}]
+        val_prep = w.prep_value(val)
+        self.assertIsInstance(val_prep, six.string_types)
+        self.assertEquals(val, json.loads(val_prep))
+
+    def test_prep_value_correct_values_json(self):
+        w = JSignatureWidget()
+        val = [{"x": [1, 2], "y": [3, 4]}]
+        val_str = '[{"x":[1,2], "y":[3,4]}]'
+        val_prep = w.prep_value(val_str)
+        self.assertIsInstance(val_prep, six.string_types)
+        self.assertEquals(val, json.loads(val_prep))
+
+    def test_prep_value_incorrect_values(self):
+        w = JSignatureWidget()
+        val = type('Foo')
+        self.assertRaises(ValidationError, w.prep_value, val)
+
+    def test_render(self):
+        w = JSignatureWidget()
+        output = w.render(name='foo', value=None)
+        # Almost useless :/
+        self.assertEqual(1, len(pq('.jsign-wrapper', output)))
+        self.assertEqual(1, len(pq('[type=hidden]', output)))
+
+    def test_render_reset_button_true(self):
+        w = JSignatureWidget(jsignature_attrs={'ResetButton': True})
+        output = w.render(name='foo', value=None)
+        self.assertEqual(1, len(pq('[type=button]', output)))
+
+    def test_render_reset_button_false(self):
+        w = JSignatureWidget(jsignature_attrs={'ResetButton': False})
+        output = w.render(name='foo', value=None)
+        self.assertEqual(0, len(pq('[type=button]', output)))